-
Notifications
You must be signed in to change notification settings - Fork 111
feat(bin): Consensus Node #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+473
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
This was referenced Jan 12, 2026
184ba44 to
3eff018
Compare
This was referenced Jan 13, 2026
2fdd3a5 to
1129756
Compare
refcell
added a commit
that referenced
this pull request
Jan 13, 2026
Consolidate runtime utilities by replacing separate build_runtime(), run_until_ctrl_c(), and run_until_ctrl_c_fallible() methods with a simpler tokio_runtime() and unified run_until_ctrl_c() that handles runtime creation internally. Ported from #395.
1129756 to
e64eddd
Compare
e64eddd to
dccda17
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
* refactor(cli-utils): simplify RuntimeManager API Consolidate runtime utilities by replacing separate build_runtime(), run_until_ctrl_c(), and run_until_ctrl_c_fallible() methods with a simpler tokio_runtime() and unified run_until_ctrl_c() that handles runtime creation internally. Ported from #395. * fix(cli-utils): bias ctrl+c
a6994e1 to
8149ba2
Compare
8149ba2 to
c11625b
Compare
2b4bd7e to
2e439da
Compare
f6c1270 to
f46b631
Compare
This was referenced Jan 14, 2026
Merged
Merged
815d79e to
209f9d7
Compare
349d858 to
54118c4
Compare
209f9d7 to
94b3348
Compare
danyalprout
previously approved these changes
Jan 14, 2026
rollup boost args base prefixes fixes
94b3348 to
57e0b75
Compare
danyalprout
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR hooks up the base consensus node, wiring in all the CLI arguments from the
client/clicrate.Closes #376.